lint: enable nilerr linter and fix errors #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
commented
May 5, 2023
| @@ -92,5 +92,5 @@ func generateKeysForRange(ctx context.Context, startIdx uint64, endIdx uint64, k | |||
| } | |||
| keys[k] = *sigAlgo | |||
| } | |||
| return nil | |||
| return nil //nolint:nilerr // OK to not return ctx.Err() | |||
There was a problem hiding this comment.
@algoidan does this look fine?
There was a problem hiding this comment.
Yes. (Also played with it a bit)
maybe for clarity, we can change line 87:
return nil // we don't need to return the ctx error, since the other goroutine will report it.
There was a problem hiding this comment.
OK I will push that change.. thanks!
algorandskiy
previously approved these changes
May 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #5361 +/- ##
==========================================
+ Coverage 55.28% 55.29% +0.01%
==========================================
Files 454 454
Lines 63772 63772
==========================================
+ Hits 35254 35263 +9
+ Misses 26115 26107 -8
+ Partials 2403 2402 -1
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
reviewed
May 5, 2023
tzaffi
previously approved these changes
May 8, 2023
cce
commented
May 10, 2023
tzaffi
approved these changes
May 10, 2023
algorandskiy
approved these changes
May 11, 2023
This was referenced May 24, 2023
PhearZero
pushed a commit
to PhearNet/crypto
that referenced
this pull request
Jan 17, 2025
tmc
pushed a commit
to tmc/go-algorand
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This enables the nilerr linter that checks for cases like this:
Test Plan
Existing tests and new linter runs should pass.