Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: fix logging to line. #5359

Merged
merged 1 commit into from
May 4, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented May 4, 2023

Summary

Fixes the Logging to print statement to indicate stdout if a file is not being used.

Test Plan

Manually ran algod and algod -o to see the different log statements.

@winder winder added the Bug-Fix label May 4, 2023
@winder winder marked this pull request as ready for review May 4, 2023 15:29
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #5359 (4ba48dd) into master (1634285) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #5359   +/-   ##
=======================================
  Coverage   55.25%   55.25%           
=======================================
  Files         454      454           
  Lines       63723    63724    +1     
=======================================
+ Hits        35208    35212    +4     
  Misses      26122    26122           
+ Partials     2393     2390    -3     
Impacted Files Coverage Δ
daemon/algod/server.go 4.30% <0.00%> (-0.03%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants