Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevOps: Add CODEOWNERS to restrict workflow edits #5353

Merged
merged 1 commit into from
May 3, 2023
Merged

DevOps: Add CODEOWNERS to restrict workflow edits #5353

merged 1 commit into from
May 3, 2023

Conversation

onetechnical
Copy link
Contributor

Summary

For slightly better security we want to add a CODEOWNERS file to restrict workflow editing.

Test Plan

N/A - try to edit workflow after merge.

@onetechnical onetechnical self-assigned this May 3, 2023
@onetechnical onetechnical requested review from a team, excalq and algobarb May 3, 2023 14:10
@algobarb algobarb removed request for a team and excalq May 3, 2023 14:10
algobarb
algobarb approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@algojohnlee algojohnlee requested review from a team, excalq and jsgranados May 3, 2023 14:13
jsgranados
jsgranados approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@jsgranados jsgranados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@onetechnical onetechnical merged commit 12bf7ff into algorand:master May 3, 2023
@onetechnical onetechnical deleted the codeowners branch May 3, 2023 15:23
This was referenced May 9, 2023
Closed
Closed
Closed
@Algo-devops-service Algo-devops-service mentioned this pull request May 22, 2023
Merged
This was referenced May 24, 2023
Merged
Merged
Merged
@Algo-devops-service Algo-devops-service mentioned this pull request Jun 12, 2023
Merged
@onetechnical onetechnical mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@excalq excalq excalq approved these changes

@algobarb algobarb algobarb approved these changes

@jsgranados jsgranados jsgranados approved these changes

Assignees

@onetechnical onetechnical

Labels
Enhancement Security Team Hyper Flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onetechnical @excalq @algobarb @jsgranados