api: Limit request body size to 10MB #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5246 +/- ##
==========================================
- Coverage 53.75% 51.35% -2.41%
==========================================
Files 450 450
Lines 56191 56193 +2
==========================================
- Hits 30207 28859 -1348
- Misses 23632 24959 +1327
- Partials 2352 2375 +23
... and 103 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algochoi
commented
Mar 31, 2023
| // Create a program with MaxTealSourceBytes+1 bytes | ||
| // This should fail inside the handler when reading the bytes from the request body. | ||
| largeProgram := []byte(strings.Repeat("a", v2.MaxTealSourceBytes+1)) | ||
| tealDisassembleTest(t, largeProgram, 400, "http: request body too large", true) |
There was a problem hiding this comment.
These tests are affected by a smaller size limit (200KB instead of 10MB) defined by MaxTealSourceBytes and will trigger the error here:
winder
previously approved these changes
Mar 31, 2023
Eric-Warehime
previously approved these changes
Apr 3, 2023
bbroder-algo
reviewed
Apr 3, 2023
|
|
||
| // Create a program with MaxTealSourceBytes+1 bytes | ||
| // This should fail inside the handler when reading the bytes from the request body. | ||
| largeProgram := []byte(strings.Repeat("a", v2.MaxTealSourceBytes+1)) |
There was a problem hiding this comment.
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
bbroder-algo
reviewed
Apr 3, 2023
bbroder-algo
reviewed
Apr 3, 2023
Co-authored-by: Bob Broderick <118225939+bbroder-algo@users.noreply.github.com>
bbroder-algo
approved these changes
Apr 3, 2023
winder
approved these changes
Apr 3, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a limit to the request body size so clients cannot send algod requests larger than 10MB.
Closes #5219
Test Plan
Adds tests in the handler to check source/dryrun request limits and adds an e2e test to check that a simulate request body >10MB fails with a 413 error.