algod: search phonebook in data directory in addition to bindir #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5235 +/- ##
==========================================
- Coverage 53.55% 53.50% -0.05%
==========================================
Files 441 441
Lines 55123 55126 +3
==========================================
- Hits 29520 29495 -25
- Misses 23317 23337 +20
- Partials 2286 2294 +8
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Shant Karakashian <55754073+algonautshant@users.noreply.github.com>
cce
approved these changes
Mar 28, 2023
algonautshant
approved these changes
Mar 29, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently phonebook.json is only searched in bin directory that might not be very convenient.
Changed to check data dir as well.
Test Plan
Tested manually