-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Mac M1 support #3920
build: Mac M1 support #3920
Conversation
Looks good. Looks like it spotted a data race in node.go |
238bc4c
to
98ef161
Compare
@@ -14,12 +14,15 @@ require ( | |||
github.com/aws/aws-sdk-go v1.16.5 | |||
github.com/chrismcguire/gobberish v0.0.0-20150821175641-1d8adb509a0e | |||
github.com/cpuguy83/go-md2man v1.0.8 // indirect | |||
github.com/davecgh/go-spew v1.1.1 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of misc little changes in go.mod
, was go mod tidy
run?
Codecov Report
@@ Coverage Diff @@
## master #3920 +/- ##
==========================================
+ Coverage 49.79% 49.82% +0.03%
==========================================
Files 409 409
Lines 68897 68903 +6
==========================================
+ Hits 34305 34334 +29
+ Misses 30888 30871 -17
+ Partials 3704 3698 -6
Continue to review full report at Codecov.
|
I'm going to close this out since #3919 has ended up with the same set of changes and has the relevant review conversation in it. I originally thought it was going to be useful to separate the go updates and the M1 changes, but it doesn't seem productive at this point. |
Summary
Updates Makefile for Mac M1 support. Currently only requires changes to account for linking to libraries installed in the new homebrew location
/opt/homebrew
.Requires #3919 (I've included that commit in this branch since without it the build will fail).
Test Plan
Built and running on my personal M1 machine.
Also needs #3813 for CI support.