Skip to content

Commit

Permalink
revisied all methods and tag them as catchpoint if they are onyl used…
Browse files Browse the repository at this point in the history
… there
  • Loading branch information
icorderi committed Mar 17, 2023
1 parent 5659531 commit e75cbb9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
14 changes: 7 additions & 7 deletions ledger/store/trackerdb/generickv/accounts_ext_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ func (r *accountsReader) AccountsTotals(ctx context.Context, catchpointStaging b
}

func (r *accountsReader) AccountsHashRound(ctx context.Context) (hashrnd basics.Round, err error) {
// TODO: nacho, is this jsut for catchpoint?
// TODO: catchpoint
return
}

func (r *accountsReader) LookupAccountAddressFromAddressID(ctx context.Context, ref trackerdb.AccountRef) (address basics.Address, err error) {
// TODO: nacho
// TODO: catchpoint
return
}

Expand All @@ -88,17 +88,17 @@ func (r *accountsReader) LookupResourceDataByAddrID(accountRef trackerdb.Account
}

func (r *accountsReader) TotalResources(ctx context.Context) (total uint64, err error) {
// TODO: nacho, check when this is called
// TODO: catchpoint
return
}

func (r *accountsReader) TotalAccounts(ctx context.Context) (total uint64, err error) {
// TODO: nacho, check when this is called
// TODO: catchpoint
return
}

func (r *accountsReader) TotalKVs(ctx context.Context) (total uint64, err error) {
// TODO: nacho, check when this is called
// TODO: catchpoint
return
}

Expand All @@ -123,12 +123,12 @@ func (r *accountsReader) OnlineAccountsAll(maxAccounts uint64) (data []trackerdb
}

func (r *accountsReader) LoadTxTail(ctx context.Context, dbRound basics.Round) (roundData []*trackerdb.TxTailRound, roundHash []crypto.Digest, baseRound basics.Round, err error) {
// TODO: nacho, check when this is used
// TODO: nacho
return
}

func (r *accountsReader) LoadAllFullAccounts(ctx context.Context, balancesTable string, resourcesTable string, acctCb func(basics.Address, basics.AccountData)) (count int, err error) {
// TODO: nacho, check when this is used
// TODO: catchpoint CLI
return
}

Expand Down
6 changes: 3 additions & 3 deletions ledger/store/trackerdb/generickv/accounts_ext_writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ func (w *accountsWriter) AccountsReset(ctx context.Context) error {
}

func (w *accountsWriter) ResetAccountHashes(ctx context.Context) (err error) {
// TODO: I'm gonan go with catchpoint
// TODO: catchpoint
return
}

func (w *accountsWriter) TxtailNewRound(ctx context.Context, baseRound basics.Round, roundData [][]byte, forgetBeforeRound basics.Round) error {
// TODO: idk
// TODO: called on commit round, and read on `loadFromDisk`
return nil
}

Expand All @@ -58,7 +58,7 @@ func (w *accountsWriter) UpdateAccountsRound(rnd basics.Round) (err error) {
}

func (w *accountsWriter) UpdateAccountsHashRound(ctx context.Context, hashRound basics.Round) (err error) {
// TODO: global? might be catchpoint only
// TODO: catchpoint
return nil
}

Expand Down

0 comments on commit e75cbb9

Please sign in to comment.