close all iterators

algorand · Apr 3, 2023 · 01f1cfa · 01f1cfa
1 parent 7712bea
commit 01f1cfa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/ledger/store/trackerdb/generickv/accounts_ext_reader.go b/ledger/store/trackerdb/generickv/accounts_ext_reader.go
@@ -120,6 +120,7 @@ func (r *accountsReader) LookupOnlineAccountDataByAddress(addr basics.Address) (
 	high := onlineAccountOnlyPartialKey(addr)
 	high[len(high)-1] += 1
 	iter := r.kvr.NewIter(low, high, true)
+	defer iter.Close()
 
 	if iter.Next() {
 		// key is <prefix>-<addr>-<rnd> = <content>
@@ -185,6 +186,7 @@ func (r *accountsReader) AccountsOnlineTop(rnd basics.Round, offset uint64, n ui
 	high[len(high)-1] += 1
 	// reverse order iterator to get high-to-low
 	iter := r.kvr.NewIter(low, high, true)
+	defer iter.Close()
 
 	var value []byte
 
@@ -301,6 +303,7 @@ func (r *accountsReader) OnlineAccountsAll(maxAccounts uint64) (data []trackerdb
 	low := []byte(kvPrefixOnlineAccount + "-")
 	high := []byte(kvPrefixOnlineAccount + ".")
 	iter := r.kvr.NewIter(low, high, false)
+	defer iter.Close()
 
 	var value []byte
 	var updround uint64

diff --git a/ledger/store/trackerdb/generickv/onlineaccounts_reader.go b/ledger/store/trackerdb/generickv/onlineaccounts_reader.go
@@ -57,6 +57,7 @@ func (r *accountsReader) LookupOnlineHistory(addr basics.Address) (result []trac
 	high := onlineAccountOnlyPartialKey(addr)
 	high[len(high)-1] += 1
 	iter := r.kvr.NewIter(low, high, false)
+	defer iter.Close()
 
 	var value []byte
 	var updround uint64

diff --git a/ledger/store/trackerdb/testsuite/badum_test.go b/ledger/store/trackerdb/testsuite/badum_test.go
@@ -40,6 +40,7 @@ func TestThis(t *testing.T) {
 
 	// acccounts
 	iter := db.NewIter([]byte{0x00}, []byte{0xFF}, false)
+	defer iter.Close()
 	for iter.Next() {
 		key := iter.Key()
 		skey := string(key)