feat(createInsightsMiddleware): support authenticatedUserToken
#5997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4802b7b:
|
f82b8c7 to
3cc7d0c
Compare
sarahdayan
commented
Jan 15, 2024
Comment on lines
+274
to
+276
| const tokenBeforeInit = | ||
| authenticatedUserTokenBeforeInit || userTokenBeforeInit; | ||
| const queuedToken = queuedAuthenticatedUserToken || queuedUserToken; |
There was a problem hiding this comment.
This all could be simpler but it can be tackled in a separate refactoring PR.
benhinchley
approved these changes
Jan 16, 2024
dhayab
reviewed
Jan 16, 2024
Haroenv
reviewed
Jan 16, 2024
dhayab
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the new
authenticatedUserTokenfrom Search Insights.When provided, it takes precedence over the
userToken. When not, or when unset, theuserTokenis used.Note
The code and tests are getting a bit more complicated than they could, but I didn't want to make a refactor in this PR to avoid complexifying the diffs. I'll do it in a separate one.
https://algolia.atlassian.net/browse/FX-2707