feat: javascript sources client #97
Conversation
openapitools.json
Outdated
| @@ -146,13 +140,32 @@ | |||
| "supportsES6": true, | |||
| "npmName": "@algolia/client-query-suggestions", | |||
| "npmVersion": "5.0.0", | |||
There was a problem hiding this comment.
We've kept the space to differentiate native openapi additionalProperties, and the one we manually add/use in our templates.
There was a problem hiding this comment.
it was removed by linting, you will have trouble keeping this space :D
There was a problem hiding this comment.
I use Save without formatting on vs code but it's a pain
There was a problem hiding this comment.
Yep but it shouldn't be edited that often, not a blocker anyway, just explaining
There was a problem hiding this comment.
I can never remember @shortcuts unlike you ahah
There was a problem hiding this comment.
I never remember it and when I do cmd k s it opens the shortcut panel 😶🌫️
There was a problem hiding this comment.
it's because it's two set of shortcuts cmd + k, trigger first mode, then you press s
There was a problem hiding this comment.
You can do cmd + k then cmd + s to see the shortcuts section :D
| "modelPropertyNaming": "original", | ||
| "supportsES6": true, | ||
| "npmName": "@algolia/client-sources", | ||
| "npmVersion": "0.0.1", |
There was a problem hiding this comment.
I did not think of that but for recommend for example, we automatically aligned to the main algoliasearch package version. Shouldn't it also be the case for this one? Do we want to ship it in the global package?
There was a problem hiding this comment.
the problem with that, is when you need a breaking change in one (API changed) they all get a major even though nothing has changed in them. I would not align them imo
There was a problem hiding this comment.
Indeed, we need to take that in consideration when releasing, as of now we only had a generic version file for the repo but it could live in each packages
clients/algoliasearch-client-javascript/client-sources/.openapi-generator-ignore
Show resolved
Hide resolved
clients/algoliasearch-client-javascript/client-sources/git_push.sh
Outdated
Show resolved
Hide resolved
clients/algoliasearch-client-javascript/client-sources/model/models.ts
Outdated
Show resolved
Hide resolved
|
@millotp complet chance ahah, just wanted to test our API :p |
| /** | ||
| * The type of the file to ingest. | ||
| */ | ||
| type: URLJobType; | ||
| input: URLJobInput; |
There was a problem hiding this comment.
I don't understand why type have the description and input does not. Both are inlined 🤔 I wonder if it's because it's from an external file
There was a problem hiding this comment.
input has its desc on the other file, I guess it will follow along thanks to TS magic
| baseHeaders: { | ||
| 'content-type': 'application/x-www-form-urlencoded', | ||
| }, | ||
| userAgent: 'Algolia for Javascript', |
There was a problem hiding this comment.
shouldn't we put the name of the client in the UA?
There was a problem hiding this comment.
Not done yet, but yes we will pass the client + version
|
Merging main and regenerating should remove the |
🧭 What and Why
Changes included:
It was mostly because we had no way to test and it was a good opportunity to test Api Client Automation.
Congrats to the team, it took me less than 30minutes to create a new client from the ground up 🚀