Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for string equality in bash #84

Merged
merged 2 commits into from
Jan 13, 2022
Merged

fix: check for string equality in bash #84

merged 2 commits into from
Jan 13, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 13, 2022

🧭 What and Why

The CI is not skipping job correctly, try to check string equality

🧪 Test

CI

@millotp millotp self-assigned this Jan 13, 2022
@millotp millotp requested a review from shortcuts January 13, 2022 09:18
@shortcuts
Copy link
Member

everything should run when changing scripts or .github, no?

(Also, testing might be easier by creating stacked PRs)

@millotp
Copy link
Collaborator Author

millotp commented Jan 13, 2022

The scripts were missing from the CTS check

@shortcuts
Copy link
Member

Actually as I said, we should stack PRs to make the CI work

@millotp
Copy link
Collaborator Author

millotp commented Jan 13, 2022

I stacked this PR to try: #83

@millotp millotp merged commit 7eb9fcf into main Jan 13, 2022
@millotp millotp deleted the fix/skip-job branch January 13, 2022 10:07
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
@millotp
fix: check for string equality in bash (#84)
0f16d42
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@millotp @shortcuts