-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: straightforward client init with apiKey and appId #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's correct right now as you basically removed it from the spec.
I woud look at Security prop, might be supported by the generator https://swagger.io/docs/specification/authentication/api-keys/
Yeah I know it's a little bit "quick and dirty", sorry for that, my goal was to quickly come up with a situation where the api key, the application id and the host were at init time. I'll try to find a better solution next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
searchClient.ts
Outdated
@@ -0,0 +1,11 @@ | |||
import { SearchApi, SearchApiApiKeys } from 'algoliasearch-client-javascript'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is ugly but I guess it's hard to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
We should just keep in mind that we should generate the client
class based on the classname
(spec tags
) otherwise it breaks our automation goal
Yes, we will automate that once the POC is finished :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me ! Love the var env
JIRA APIC-157