Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix built client cache #65

Merged
merged 6 commits into from
Jan 6, 2022
Merged

chore(ci): fix built client cache #65

merged 6 commits into from
Jan 6, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jan 5, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

Cache key is not based on the dist folder instead of the lock file

🧪 Test

CI :D

@shortcuts shortcuts force-pushed the chore/ci-clients-cache branch from 1b46e2d to 801075c Compare January 5, 2022 17:43
@shortcuts shortcuts self-assigned this Jan 5, 2022
@shortcuts shortcuts requested review from a team and damcou and removed request for a team January 5, 2022 19:09
@shortcuts shortcuts marked this pull request as ready for review January 5, 2022 19:09
millotp
millotp previously approved these changes Jan 6, 2022
View reviewed changes
@shortcuts shortcuts force-pushed the chore/ci-clients-cache branch from 0bade21 to 3b42468 Compare January 6, 2022 08:53
@shortcuts shortcuts requested a review from millotp January 6, 2022 09:05
millotp
millotp approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@shortcuts shortcuts merged commit cc57be8 into main Jan 6, 2022
@shortcuts shortcuts deleted the chore/ci-clients-cache branch January 6, 2022 09:07
shortcuts added a commit that referenced this pull request Apr 22, 2022
@shortcuts
chore(ci): fix built client cache (#65)
9139902
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shortcuts @millotp