fix(scripts): remove generation commit from changelogs #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
draft until I update the cache, lock should clear cache 🤔 |
millotp
reviewed
May 23, 2022
| @@ -237,6 +244,12 @@ async function createReleaseIssue(): Promise<void> { | |||
| const commit = parseCommit(commitMessage); | |||
|
|
|||
| if ('error' in commit) { | |||
There was a problem hiding this comment.
we could have 'error: null' in ParsedCommit for a cleaner check here
There was a problem hiding this comment.
Good idea, will also apply it!
I'm doing an other PR to try to prevent duplicate stuff and make the version bump possible |
millotp
approved these changes
May 24, 2022
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
May 24, 2022
algolia/api-clients-automation#534 Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
This was referenced May 24, 2022
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
yarn installafter generating version bump to update the lock file🧪 Test
CI :D