Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cts): group tests per method #53

Merged
merged 7 commits into from
Jan 3, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-231

Changes included:

  • Change javascript.mustache CTS template file to allow group tests per method.
  • Remove ts-node dependency.
  • Update generateCTS.ts script to provide a blockName string to allow grouping.

As our clients are growing, and methods are usually not testable with a single test, this PR aims at creating groups of tests per method.

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Dec 28, 2021
sbellone
sbellone previously approved these changes Dec 29, 2021
Copy link
Contributor

@sbellone sbellone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, just a small comment from a reviewer not knowing the code very well!

Base automatically changed from feat/APIC-230/search-dictionary-recommend-cts to main December 29, 2021 12:09
@shortcuts shortcuts requested a review from millotp January 3, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants