Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cts): add tests for search, recommend and dictionaries endpoints #52

Merged
merged 4 commits into from
Dec 29, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Dec 28, 2021

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-230

Changes included:

  • Add tests for search, recommend and dictionaries endpoints
  • Remove required where it was not needed
  • Add check in the generateCTS.ts file to make sure we don't provide empty files

🧪 Test

CI :D

@shortcuts shortcuts requested a review from damcou December 28, 2021 16:00
@shortcuts shortcuts self-assigned this Dec 28, 2021
Copy link
Contributor

@sbellone sbellone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from feat/APIC-229/specs-consistency to main December 29, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants