chore(cts): update dependency on cts generation for java #505
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
CTS for PHP doesn't have any composer file. Is it intended? Or something we need to work on? How does it resolve the latest version of the PHP package? |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Currently it uses the phpunit contained in the PHP client (require-dev dependency) : Is it a problem ? |
Not a problem at all! I was just curious how it works. I think it's good because what we're trying to do here is to make sure the CTS run with the latest local version. |
| @@ -9,7 +9,7 @@ public abstract class CtsManager { | |||
|
|
|||
| public abstract void addSupportingFiles(List<SupportingFile> supportingFiles); | |||
|
|
|||
| public List<Object> getPackageDependencies() { | |||
| protected List<Object> getPackageDependencies() { | |||
There was a problem hiding this comment.
It was public unnecessarily.
There was a problem hiding this comment.
As this function is only used by js it could be in the JavascriptCtsManager class only
| @@ -9,7 +9,7 @@ public abstract class CtsManager { | |||
|
|
|||
| public abstract void addSupportingFiles(List<SupportingFile> supportingFiles); | |||
|
|
|||
| public List<Object> getPackageDependencies() { | |||
| protected List<Object> getPackageDependencies() { | |||
There was a problem hiding this comment.
As this function is only used by js it could be in the JavascriptCtsManager class only
| ); | ||
| } | ||
|
|
||
| protected void addExtraToBundle(Map<String, Object> bundle) { |
| } | ||
|
|
||
| dependencies { | ||
| testImplementation 'com.algolia:algoliasearch-client-java:{{packageVersion}}-SNAPSHOT' |
There was a problem hiding this comment.
do you know if semver works with the SNAPSHOT suffix ? in that case we could maybe remove SNAPSHOT everywhere and just have it in the clients.config.json file
There was a problem hiding this comment.
Actually I don't remember what SNAPSHOT means in Java. Can you remind me? Is it always SNAPSHOT, or can it be something else?
There was a problem hiding this comment.
it's like experimental, it will be released on a different central repository that user have to opt in if they want to use the SNAPSHOT, so once this is out of beta the SNAPSHOT will be removed.
I read that semver accepts suffix value after dash but I'm not sure
There was a problem hiding this comment.
but it's fine it this stays here it works well like this, it's just a small improvement if possible
There was a problem hiding this comment.
semver works with ${major}.${minor}.${patch}-${WHATEVER-POSTFIX}.${number} format, which means something like 1.0.0-beta.9. Ending with SNAPSHOT but without number wouldn't work AFAIK.
🧭 What and Why
Changes included: