-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix codegen restore #491
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
951a21e
to
8eecb2c
Compare
8eecb2c
to
4dedfc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
description: Type of artifacts to restore (`all` | `specs` | `utils`) | ||
description: Type of artifacts to restore (`all` | `specs` | `js_utils`) | ||
required: false | ||
php: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now the goal will be to make it dynamic :/
@@ -189,13 +193,6 @@ jobs: | |||
key: ${{ matrix.client.cacheKey }} | |||
path: ${{ matrix.client.path }} | |||
|
|||
- name: Download bundled specs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was duplicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's go with this for now !
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
Not sure if it's enough, definitely not the best, but should fix restoring artifacts issues like in #487 for jobs that did not ran
🧪 Test
CI :D