Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix codegen restore #491

Merged
merged 5 commits into from
May 11, 2022
Merged

chore: fix codegen restore #491

merged 5 commits into from
May 11, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented May 10, 2022

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Not sure if it's enough, definitely not the best, but should fix restoring artifacts issues like in #487 for jobs that did not ran

🧪 Test

CI :D

@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit b978c05
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/627a8cd0e2ada80009f83ebc

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 10, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts shortcuts force-pushed the fix/codegen-restore branch from 951a21e to 8eecb2c Compare May 10, 2022 15:16
@shortcuts shortcuts force-pushed the fix/codegen-restore branch from 8eecb2c to 4dedfc1 Compare May 10, 2022 15:28
@shortcuts shortcuts self-assigned this May 10, 2022
@shortcuts shortcuts requested a review from millotp May 10, 2022 15:43
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@shortcuts shortcuts marked this pull request as ready for review May 10, 2022 16:00
@shortcuts shortcuts requested a review from millotp May 10, 2022 16:00
description: Type of artifacts to restore (`all` | `specs` | `utils`)
description: Type of artifacts to restore (`all` | `specs` | `js_utils`)
required: false
php:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now the goal will be to make it dynamic :/

@@ -189,13 +193,6 @@ jobs:
key: ${{ matrix.client.cacheKey }}
path: ${{ matrix.client.path }}

- name: Download bundled specs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was duplicated

@shortcuts shortcuts enabled auto-merge (squash) May 10, 2022 16:31
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go with this for now !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants