chore: remove push and local changes check #457
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| @@ -196,25 +195,13 @@ async function createReleaseIssue(): Promise<void> { | |||
| ); | |||
| } | |||
|
|
|||
| if ( | |||
There was a problem hiding this comment.
Does the release process depends on local files ?
I think if it's use on the CI this test should stay
There was a problem hiding this comment.
This script is only triggered manually with yarn release, it's not running on the CI, it only parses main commits and create an issue, the release part is on issue closed
There was a problem hiding this comment.
Yes but maybe in the future we will trigger the release from the CI, this check can stay if you add CI=true, just to be sure
There was a problem hiding this comment.
Or we can re-add it in the future, for now it's not necessary to have it
There was a problem hiding this comment.
ahah you're stubborn, we will forget it later but okay
There was a problem hiding this comment.
I just feel like this type of error will make you think you might do something bad/wrong keeping non-clean branches, while it does/should not interact with it at all
There was a problem hiding this comment.
Indeed we can run this from the CI in the future (I think it's better that way), but we can still remove this code block. It's there just to avoid error with git pull, but it won't matter especially on the CI when we run this from a clean working directory.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
I'm not yet sure why, but I've been able to push to main while trying to release. It's weird since at this point we are using the local GH user and I'm not in the allowed list of who can push to main
Steps I've did:
mainwith originmainyarn releaseI'm not sure if this
git pushstep is necessary, but I've been able to create the release issue without it: #456🧪 Test
CI :D