fix(php): format part 2 #443
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
.github/.cache_version
Outdated
| @@ -1 +1 @@ | |||
| 9.2 | |||
| 9.2.1 | |||
There was a problem hiding this comment.
you changed the config file so no need to bump the cache
There was a problem hiding this comment.
see #443 (comment), I wanted to try full clear to see if I get the same output
There was a problem hiding this comment.
yes it will have the same effect of clearing the cache, changing the config changes the cache key
There was a problem hiding this comment.
this file should rarely be used now
There was a problem hiding this comment.
ahah you didn't had to revert it, it was just an advice
There was a problem hiding this comment.
ah actually it does not run codegen without this change :(
There was a problem hiding this comment.
ah yes because even though the cache key is different it doesn't set any RUN_ variable, I guess more common files should be added.
There was a problem hiding this comment.
I guess this should be enough d7bdf7c
(I need the codegen to run in this PR)
scripts/ci/setRunVariables.ts
Outdated
| const PHP_CLIENT_FOLDER = getLanguageFolder('php'); | ||
|
|
||
| // Files that are common to every clients | ||
| const CLIENTS_COMMON_FILES = ['config/clients.config.json']; |
There was a problem hiding this comment.
you could add openapitools.json to this list
Yep... looks like so |
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
I should've used the
.prettierignore. Since the spread code script rely on the path, it kinda broke the PHP repo folders.🧪 Test
CI :D