Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): responseFields description #4399

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jan 24, 2025

🧭 What and Why

Port an edit from the docs repo:
https://github.com/algolia/doc/pull/9693

Clarifying the behavior of responseFields with empty lists,
and slightly adjusting the style.

🎟 JIRA Ticket:

Changes included:

  • List changes

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 24, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by a85e75415baab248a25a9028b03b5d997b18f2d6
🍃 Generated commit 81017e78fdad55f95e3b5563edf26ba1732428fa
🌲 Generated branch generated/fix/specs/responseFields
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1661
go 1658
php 1515
csharp 1434
java 1108
python 1081
ruby 855
swift 735

@kai687 kai687 marked this pull request as ready for review January 24, 2025 18:02
@kai687 kai687 requested a review from a team as a code owner January 24, 2025 18:02
@kai687 kai687 requested review from Fluf22 and millotp January 24, 2025 18:02
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fluf22 Fluf22 merged commit 506b8a5 into main Jan 24, 2025
28 checks passed
@Fluf22 Fluf22 deleted the fix/specs/responseFields branch January 24, 2025 18:18
algolia-bot added a commit that referenced this pull request Jan 24, 2025
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 24, 2025
algolia/api-clients-automation#4399

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants