Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(php): formatter #439

Merged
merged 2 commits into from
Apr 27, 2022
Merged

fix(php): formatter #439

merged 2 commits into from
Apr 27, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Apr 27, 2022

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

The PHP formatter tries to format the vendor folder, this should fix the scope to only fix the lib folder.

🧪 Test

CI :D

@netlify
Copy link

netlify bot commented Apr 27, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 308011f
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6269256f2cbb3400097861de

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 27, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts shortcuts marked this pull request as ready for review April 27, 2022 11:26
@shortcuts shortcuts self-assigned this Apr 27, 2022
@shortcuts shortcuts requested review from a team, eunjae-lee and damcou and removed request for a team April 27, 2022 11:26
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! you could add vendor to .prettierignore also

@shortcuts
Copy link
Member Author

shortcuts commented Apr 27, 2022

Ah it seems to replace === 2aa57a4#diff-72b034f6eb4cb86f14451db85a35d95e83620fb1f6c67ee3fbee5000e4579604L440, idk where it comes from yet

@shortcuts
Copy link
Member Author

Ok I guess I'll merge like that and wait for @damcou to answer/apply a fix, in the meantime it does not block other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants