-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): rename version tag #437
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no other occurrences? I thought I saw it elsewhere 🤔
In InstantSearch, we use Edit: I just confirmed only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah it's in the GitHub actions
edit: the commit are sent with the v
prefix
edit2: the docs also have some mentions
We can keep |
It's just that we will have difference in naming here and there, like the release issue will also have the |
Like those they won't work if we keep the v, no? |
Ah that's a good catch. I'll revisit the two whole scripts and check what needs to be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🧭 What and Why
https://algolia.atlassian.net/browse/APIC-450
Changes included:
The release process creates tags like
v5.0.0
for release. However, actually our each repository doesn't havev
prefix at all.So this PR renames the tag format to be aligned with the existing tags.
(Also, on the PHP repo, release is triggered by a git tag, and the format matters.)
🧪 Test