Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): rename version tag #437

Merged
merged 4 commits into from
Apr 28, 2022
Merged

chore(ci): rename version tag #437

merged 4 commits into from
Apr 28, 2022

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Apr 27, 2022

🧭 What and Why

https://algolia.atlassian.net/browse/APIC-450

Changes included:

The release process creates tags like v5.0.0 for release. However, actually our each repository doesn't have v prefix at all.

So this PR renames the tag format to be aligned with the existing tags.

(Also, on the PHP repo, release is triggered by a git tag, and the format matters.)

🧪 Test

@netlify
Copy link

netlify bot commented Apr 27, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit a8531e3
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/626a58af3715c1000889f50b

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 27, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no other occurrences? I thought I saw it elsewhere 🤔

@eunjae-lee eunjae-lee requested a review from shortcuts April 27, 2022 09:44
@eunjae-lee
Copy link
Contributor Author

There is not other occurences? I thought I saw it elsewhere 🤔

In InstantSearch, we use vx.y.z.

Edit: I just confirmed only algoliasearch-client-go has v prefix 😅 I'm going to update this PR. Wait a sec!

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it's in the GitHub actions

edit: the commit are sent with the v prefix
edit2: the docs also have some mentions

@eunjae-lee
Copy link
Contributor Author

Ah it's in the GitHub actions

edit: the commit are sent with the v prefix

We can keep v for the commit message, tho?

@shortcuts
Copy link
Member

We can keep v for the commit message, tho?

It's just that we will have difference in naming here and there, like the release issue will also have the v while we publish the tag without it

@shortcuts
Copy link
Member

@eunjae-lee
Copy link
Contributor Author

Like those they won't work if we keep the v, no?

https://github.com/algolia/api-clients-automation/blob/main/scripts/release/process-release.ts#L162-L164

Ah that's a good catch. I'll revisit the two whole scripts and check what needs to be changed.

@eunjae-lee eunjae-lee marked this pull request as draft April 27, 2022 09:52
@eunjae-lee eunjae-lee marked this pull request as ready for review April 28, 2022 09:12
@eunjae-lee eunjae-lee requested a review from shortcuts April 28, 2022 09:12
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants