Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): extend Analytics descriptions #4360

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Conversation

gazconroy
Copy link
Contributor

🧭 What and Why

Extending the Analytics OAS to cover what was previously in the old (non-OAS) spec.

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DOC-1578

Changes included:

  • Updating and extending some of the descriptions
  • Adding an operation to the revenue tag

@gazconroy gazconroy requested a review from a team as a code owner January 15, 2025 15:42
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 15, 2025

🪓 The generated code will be pushed at the end of the CI.

Action triggered by commit 2cf65e97092d4e235b4b1f0e20e472dba09a585c.

Please do not push any generated code to this pull request.

@gazconroy gazconroy requested a review from kai687 January 15, 2025 15:42
gazconroy and others added 2 commits January 16, 2025 09:02
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@millotp millotp merged commit 22167b8 into main Jan 16, 2025
3 checks passed
@millotp millotp deleted the fix/improve-analytics branch January 16, 2025 09:57
algolia-bot added a commit that referenced this pull request Jan 16, 2025
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4360

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants