Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): different summaries for saveObject/addOrUpdate methods #4223

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Dec 10, 2024

🧭 What and Why

Better distinguish the saveObject and addOrUpdateObject methods with distinct summaries.

🎟 JIRA Ticket:

Changes included:

  • List changes

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 10, 2024

✔️ Code generated!

Name Link
🪓 Triggered by c34ca8bff560186a2c64efc513d819793d3da3a6
🍃 Generated commit 46d8d0e2bddcb9e57805358e73e79096d6e80ec1
🌲 Generated branch generated/fix/add-records-name
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1638
go 1601
php 1474
csharp 1446
python 1120
java 1109
ruby 867
swift 744

@kai687 kai687 marked this pull request as ready for review December 10, 2024 10:05
@kai687 kai687 requested a review from a team as a code owner December 10, 2024 10:05
@kai687 kai687 requested review from Fluf22 and shortcuts December 10, 2024 10:05
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better 👍🏻

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shortcuts shortcuts merged commit 866d859 into main Dec 10, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/add-records-name branch December 10, 2024 10:33
algolia-bot added a commit that referenced this pull request Dec 10, 2024
…4223) (generated) [skip ci]

Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Dec 10, 2024
…enerated)

algolia/api-clients-automation#4223

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants