Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guides: push records.json location [skip-bc] #4196

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

we shouldn't recommend to read a file at the root of the disk, we can keep it at the script level

@shortcuts shortcuts self-assigned this Dec 4, 2024
@shortcuts shortcuts requested a review from a team as a code owner December 4, 2024 13:34
@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 4, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 572edc1724b3f276857ef27ccde1dbc9843a0648
🍃 Generated commit a3a857f622fc52952b89728d6f60923ebb0178d3
🌲 Generated branch generated/fix/guides-push
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1662
javascript 1602
php 1509
csharp 1402
java 1129
python 1065
ruby 871
swift 755

@shortcuts shortcuts changed the title fix(guides): push records.json location fix(guides): push records.json location [skip-bc] Dec 4, 2024
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@shortcuts shortcuts changed the title fix(guides): push records.json location [skip-bc] guides: push records.json location [skip-bc] Dec 4, 2024
@shortcuts shortcuts enabled auto-merge (squash) December 4, 2024 13:35
@shortcuts shortcuts merged commit 8904f51 into main Dec 4, 2024
27 of 28 checks passed
@shortcuts shortcuts deleted the fix/guides-push branch December 4, 2024 13:47
algolia-bot added a commit that referenced this pull request Dec 4, 2024
…p ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants