Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(generators): allow per-spec timeouts [skip-bc] #4173

Merged
merged 29 commits into from
Dec 5, 2024
Merged

feat(generators): allow per-spec timeouts [skip-bc] #4173

merged 29 commits into from
Dec 5, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Nov 29, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3255 https://algolia.atlassian.net/browse/DI-3230

Changes included:

@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 29, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by 3b60b444a924171ccd00bf9c49fa837f8c0e01d8
🍃 Generated commit 3d2288ce199686fe1adea4fa521bb1fc30ffd8a8
🌲 Generated branch generated/feat/timeouts-per-specs
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1644
go 1602
php 1507
csharp 1370
java 1094
python 1086
ruby 876
swift 757

@shortcuts shortcuts changed the title feat(generators): allow per-spec timeouts feat(generators): allow per-spec timeouts [skip-bc] Nov 29, 2024
@shortcuts shortcuts self-assigned this Dec 3, 2024
@shortcuts shortcuts force-pushed the feat/timeouts-per-specs branch from 367e1a3 to 19d190d Compare December 3, 2024 17:45
@shortcuts shortcuts force-pushed the feat/timeouts-per-specs branch from 19d190d to 7aca9b3 Compare December 3, 2024 17:46
@shortcuts shortcuts marked this pull request as ready for review December 3, 2024 17:47
@shortcuts shortcuts requested a review from a team as a code owner December 3, 2024 17:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

🚀 Deployed on https://674f476876451f0c3a364a33--api-clients-automation.netlify.app

millotp
millotp reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very cool

@shortcuts shortcuts force-pushed the feat/timeouts-per-specs branch from aa8514b to 47a8901 Compare December 5, 2024 09:21
@shortcuts shortcuts force-pushed the feat/timeouts-per-specs branch from 47a8901 to 61bca9d Compare December 5, 2024 09:21
@shortcuts shortcuts merged commit 106d643 into main Dec 5, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/timeouts-per-specs branch December 5, 2024 12:55
algolia-bot added a commit that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (#4173) (generate…
a14702d 
…d) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
77ef39e 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
0d480c3 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
e4b5960 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
fa44a7d 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
c04eb50 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
f2a4321 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
0f16505 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
ca5542c 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
0ea2acd 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Dec 5, 2024
@algolia-bot @shortcuts
@millotp @Fluf22
feat(generators): allow per-spec timeouts [skip-bc] (generated)
3654be8 
algolia/api-clients-automation#4173

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shortcuts @algolia-bot @millotp @Fluf22