Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): allow extra properties, lax type check #4143

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Nov 22, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3307

Changes included:

we don't want to throw if the response contains unknown fields, but all of them should be treated as additional properties

@shortcuts shortcuts self-assigned this Nov 22, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 22, 2024

✔️ Code generated!

Name Link
🪓 Triggered by f0046c0ad84f20ba0a7bd07de6c2bcb2421fd1ea
🍃 Generated commit 3a3890d8c7d7672ea965c246ad372be19a0e54fb
🌲 Generated branch generated/fix/python-type-check-and-additional-properties
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
python 1078

@shortcuts shortcuts marked this pull request as ready for review December 11, 2024 13:00
@shortcuts shortcuts requested a review from a team as a code owner December 11, 2024 13:00
@shortcuts shortcuts enabled auto-merge (squash) December 12, 2024 09:04
@shortcuts shortcuts requested a review from millotp December 16, 2024 13:52
@shortcuts shortcuts merged commit 4d3fe82 into main Dec 16, 2024
16 checks passed
@shortcuts shortcuts deleted the fix/python-type-check-and-additional-properties branch December 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants