Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make ci push deleted files #408

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Apr 20, 2022

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Those delete files were not removed because they were not cached (the path has changed), but still on the repo.

🧪 Test

CI :D

@netlify
Copy link

netlify bot commented Apr 20, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 109b730
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6260274786a8a40008c4b7be

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 20, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts shortcuts force-pushed the chore/make-ci-push-deleted-files branch from 27d58e4 to 964b61e Compare April 20, 2022 15:25
@shortcuts shortcuts marked this pull request as draft April 20, 2022 15:27
@shortcuts shortcuts force-pushed the chore/make-ci-push-deleted-files branch from 964b61e to 109b730 Compare April 20, 2022 15:31
@shortcuts shortcuts requested review from a team, eunjae-lee and millotp and removed request for a team April 20, 2022 15:42
@shortcuts shortcuts self-assigned this Apr 20, 2022
@shortcuts shortcuts marked this pull request as ready for review April 20, 2022 15:44
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are those files deleted ?

@shortcuts
Copy link
Member Author

Why are those files deleted ?

Do you mean why it's not renamed instead?

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right sorry I forgot they changed name

@shortcuts shortcuts merged commit cbf57aa into main Apr 20, 2022
@shortcuts shortcuts deleted the chore/make-ci-push-deleted-files branch April 20, 2022 15:58
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 20, 2022
algolia/api-clients-automation#408

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Apr 20, 2022
algolia/api-clients-automation#408

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
shortcuts added a commit that referenced this pull request Apr 22, 2022
shortcuts added a commit that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants