Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): update browse iterator #4058

Merged
merged 13 commits into from
Oct 31, 2024
Merged

fix(clients): update browse iterator #4058

merged 13 commits into from
Oct 31, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Oct 31, 2024

🧭 What and Why

🎟 JIRA Ticket: CR-7214

Changes included:

🧪 Test

@Fluf22 Fluf22 requested a review from a team as a code owner October 31, 2024 06:43
@Fluf22 Fluf22 requested review from morganleroi and millotp October 31, 2024 06:43
@Fluf22 Fluf22 self-assigned this Oct 31, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 31, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 74af41b2281b95a42427b748e612c4d14fb4596d
🍃 Generated commit 18d43337e3d81173c8371e73c05c2b659fcd6347
🌲 Generated branch generated/fix/browse-rules-validator
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1646
javascript 1614
php 1503
csharp 1375
java 1105
python 1033
ruby 933
swift 767

@Fluf22 Fluf22 force-pushed the fix/browse-rules-validator branch from 4dfe32b to 84225c6 Compare October 31, 2024 07:00
@Fluf22 Fluf22 force-pushed the fix/browse-rules-validator branch 2 times, most recently from 7af02ab to eb26227 Compare October 31, 2024 11:18
@Fluf22 Fluf22 force-pushed the fix/browse-rules-validator branch from 9fb4adf to aecc7c2 Compare October 31, 2024 14:08
@Fluf22 Fluf22 force-pushed the fix/browse-rules-validator branch from ecd2634 to 9f794ed Compare October 31, 2024 15:31
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Fluf22
Copy link
Contributor Author

Fluf22 commented Oct 31, 2024

I'm not sure if that means:

  • au quai/okay
  • joli/lgtm
  • beach/bitch

@Fluf22 Fluf22 enabled auto-merge (squash) October 31, 2024 15:45
@shortcuts
Copy link
Member

it's NICE

@Fluf22 Fluf22 merged commit 6254217 into main Oct 31, 2024
25 checks passed
@Fluf22 Fluf22 deleted the fix/browse-rules-validator branch October 31, 2024 16:06
algolia-bot added a commit that referenced this pull request Oct 31, 2024
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 31, 2024
algolia/api-clients-automation#4058

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 31, 2024
algolia/api-clients-automation#4058

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 31, 2024
algolia/api-clients-automation#4058

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 31, 2024
algolia/api-clients-automation#4058

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 31, 2024
algolia/api-clients-automation#4058

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 31, 2024
algolia/api-clients-automation#4058

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 31, 2024
algolia/api-clients-automation#4058

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 31, 2024
algolia/api-clients-automation#4058

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants