Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): support synonyms type in camel case [skip-bc] #4031

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Oct 25, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3108

Changes included:

see https://github.com/algolia/AlgoliaWeb/pull/22442#discussion_r1816448163 and https://github.com/algolia/AlgoliaWeb/pull/22442#discussion_r1816451248 for context

the API accepts both casing, and the search is case insensitive, the camel case is the more obvious one and was supported in the previous major

@shortcuts shortcuts self-assigned this Oct 25, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 25, 2024

✔️ Code generated!

Name Link
🪓 Triggered by b9f9acf38999dd1e60f79f1d77c07f92beb5b40f
🍃 Generated commit b9b8e142523baf943c53402add3b91c54860ab77
🌲 Generated branch generated/fix/synonyms-camel-case
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1696
go 1624
php 1481
csharp 1260
java 1128
python 1029
ruby 859
swift 753

@shortcuts shortcuts changed the title fix(specs): support synonyms type in camel case fix(specs): support synonyms type in camel case [skip-bc] Oct 25, 2024
@shortcuts
Copy link
Member Author

I guess this will fail for some clients since it generates the same name

@shortcuts shortcuts marked this pull request as ready for review October 25, 2024 13:27
@shortcuts shortcuts requested a review from a team as a code owner October 25, 2024 13:27
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better !

@shortcuts shortcuts merged commit 32f9f4d into main Oct 28, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/synonyms-camel-case branch October 28, 2024 12:37
algolia-bot added a commit that referenced this pull request Oct 28, 2024
…nerated) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 28, 2024
algolia/api-clients-automation#4031

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants