chore: make CI push code to main #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
reviewed
Apr 11, 2022
Good eyes 👀 |
millotp
approved these changes
Apr 12, 2022
| console.log(`Checking codegen status on '${baseBranch}'.`); | ||
|
|
||
| const nbDiff = await getNbGitDiff({ | ||
| branch: 'origin/generated/main', | ||
| branch: baseBranch, |
There was a problem hiding this comment.
baseBranch is not very true, it should be currentBranch, but it's not important
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-426
Changes included:
Remove the
generated/mainlogic to make the CI push generated code tomainas a short term solution. We should iterate on the long term solution once we have time to dedicate to this.Next step:
GitHub hook to remove generated code on
pre-commit🧪 Test
CI :D