Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(insights): Example event name should change with eventType #3619

Merged
merged 2 commits into from
Aug 30, 2024
Merged

docs(insights): Example event name should change with eventType #3619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd1db48
docs(insights): Example event name should change with eventType
JonathanMontane Aug 30, 2024
86ae99e
still run benchmark server for swift
millotp Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/cts/runCts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ export async function runCts(
clients: string[],
suites: Record<CTSType, boolean>,
): Promise<void> {
const withBenchmarkServer = suites.benchmark && (clients.includes('search') || clients.includes('all'));
const withBenchmarkServer =
suites.benchmark && (clients.includes('search') || clients.includes('all') || languages.includes('swift'));
const withClientServer = suites.client && (clients.includes('search') || clients.includes('all'));
const closeTestServer = await startTestServer({
...suites,
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/AddedToCartObjectIDs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Product Added To Cart
eventType:
$ref: './ConversionEvent.yml'
eventSubtype:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/AddedToCartObjectIDsAfterSearch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Product Added To Cart
eventType:
$ref: './ConversionEvent.yml'
eventSubtype:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/ClickedFilters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Filter Clicked
eventType:
$ref: './ClickEvent.yml'
index:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/ClickedObjectIDs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Product Clicked
eventType:
$ref: './ClickEvent.yml'
index:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/ClickedObjectIDsAfterSearch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Product Clicked
eventType:
$ref: './ClickEvent.yml'
index:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/ConvertedFilters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Filter Converted
eventType:
$ref: './ConversionEvent.yml'
index:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/ConvertedObjectIDs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Product Converted
eventType:
$ref: './ConversionEvent.yml'
index:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/ConvertedObjectIDsAfterSearch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Product Converted
eventType:
$ref: './ConversionEvent.yml'
index:
Expand Down
1 change: 0 additions & 1 deletion specs/insights/common/schemas/EventAttributes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ eventName:
Consider naming events consistently—for example, by adopting Segment's
[object-action](https://segment.com/academy/collecting-data/naming-conventions-for-clean-data/#the-object-action-framework)
framework.
example: Product Clicked

index:
type: string
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/PurchasedObjectIDs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Product Purchased
eventType:
$ref: './ConversionEvent.yml'
eventSubtype:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/PurchasedObjectIDsAfterSearch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Product Purchased
eventType:
$ref: './ConversionEvent.yml'
eventSubtype:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/ViewedFilters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Filter Viewed
eventType:
$ref: './ViewEvent.yml'
index:
Expand Down
1 change: 1 addition & 0 deletions specs/insights/common/schemas/ViewedObjectIDs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ additionalProperties: false
properties:
eventName:
$ref: './EventAttributes.yml#/eventName'
example: Product Viewed
eventType:
$ref: './ViewEvent.yml'
index:
Expand Down
Loading