Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): helper to switch API key in use #3616

Merged
merged 49 commits into from
Sep 6, 2024
Merged

feat(clients): helper to switch API key in use #3616

merged 49 commits into from
Sep 6, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Aug 29, 2024 •
edited by millotp
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-2727

Changes included:

Language First implementation Validated with test
C# [x] [x]
Dart [x] [x]
Go [x] [x]
Java [x] [x]
Javascript [x] [x]
Kotlin [x] [x]
PHP [x] [x]
Python [x] [x]
Ruby [x] [x]
Scala [x] [x]
Swift [x] [x]

@Fluf22 Fluf22 self-assigned this Aug 29, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 29, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by 21c7afb52969067be49f320c3ddbd1fa921228de
🍃 Generated commit 361c8f22901bb4f345054721ba88ecf79014a754
🌲 Generated branch generated/fix/switch-api-key
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1631
php 1466
csharp 1184
python 987
java 969
ruby 957
swift 769
go 555

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

🚀 Deployed on https://66dabf7219010dd7b0662c04--api-clients-automation.netlify.app

@Fluf22 Fluf22 force-pushed the fix/switch-api-key branch 8 times, most recently from 63f0d6f to 6f8f40a Compare September 3, 2024 15:00
@Fluf22 Fluf22 force-pushed the fix/switch-api-key branch from 0519875 to 747c39f Compare September 4, 2024 16:37
@millotp millotp marked this pull request as ready for review September 5, 2024 22:49
@millotp millotp requested a review from a team as a code owner September 5, 2024 22:49
millotp
millotp previously approved these changes Sep 5, 2024
View reviewed changes
millotp
millotp previously approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg !

@Fluf22 Fluf22 requested a review from millotp September 6, 2024 08:25
shortcuts
shortcuts approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gggggg

@Fluf22 Fluf22 enabled auto-merge (squash) September 6, 2024 08:33
@Fluf22 Fluf22 merged commit 2c65a8d into main Sep 6, 2024
28 checks passed
@Fluf22 Fluf22 deleted the fix/switch-api-key branch September 6, 2024 08:41
algolia-bot added a commit that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (#3616) (generated) [s…
663670f 
…kip ci]

Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
2da109e 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
388689a 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
496b93a 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
5ba70b1 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
d742815 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
d6571f2 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
13a473b 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
d9e88c1 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
23cfee8 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
343019b 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Sep 6, 2024
@algolia-bot @Fluf22 @millotp
feat(clients): helper to switch API key in use (generated)
4707bd0 
algolia/api-clients-automation#3616

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fluf22 @algolia-bot @millotp @shortcuts