Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spec): apply eslint APIC-416 #357

Merged
merged 1 commit into from
Apr 12, 2022
Merged

fix(spec): apply eslint APIC-416 #357

merged 1 commit into from
Apr 12, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Apr 8, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-416

Apply eslint fixes

@netlify
Copy link

netlify bot commented Apr 8, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 5b71c02
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6255318a6689aa0008abe8a2
😎 Deploy Preview https://deploy-preview-357--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@millotp millotp mentioned this pull request Apr 8, 2022
Merged
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 8, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@millotp millotp requested review from shortcuts and damcou and removed request for shortcuts April 8, 2022 14:10
@millotp millotp self-assigned this Apr 8, 2022
@millotp millotp force-pushed the style/eslint-enum branch from 87040bd to 9d77035 Compare April 8, 2022 15:14
damcou
damcou reviewed Apr 11, 2022
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we just saw, there are still pending issue when I run yarn specs:lint specs/ --fix , let's check that together tomorrow.

@millotp millotp force-pushed the style/eslint-enum branch from 9d77035 to 2d36490 Compare April 12, 2022 07:53
@millotp
Copy link
Collaborator Author

millotp commented Apr 12, 2022

I fixed the issue, you can check the format on everything with the command: yarn specs:lint .

@millotp millotp requested a review from damcou April 12, 2022 08:01
damcou
damcou approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, changes seems to be correct! 🚀

@millotp millotp merged commit 9af3d59 into style/eslint-enum Apr 12, 2022
@millotp millotp deleted the fix/apply-style branch April 12, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

@shortcuts shortcuts Awaiting requested review from shortcuts

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millotp @algolia-bot @damcou