Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): exports type field #3569

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

closes algolia/algoliasearch-client-javascript#1540, thanks a lot @Zach-Jaensch for the contribution

@shortcuts shortcuts self-assigned this Aug 21, 2024
@shortcuts shortcuts requested a review from a team as a code owner August 21, 2024 10:20
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 21, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 653980d86fd3d6f18192e6f7e93850f96cbc8851
🍃 Generated commit 309600e20be974a75ce3d3ba4a46690f7010d977
🌲 Generated branch generated/fix/javascript-exports-field
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1377

Copy link

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@shortcuts shortcuts merged commit 73868d6 into main Aug 21, 2024
12 checks passed
@shortcuts shortcuts deleted the fix/javascript-exports-field branch August 21, 2024 11:43
algolia-bot added a commit that referenced this pull request Aug 21, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 21, 2024
algolia/api-clients-automation#3569

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module types missing from manifest
3 participants