feat(spec/search): add vault endpoints to spec (APIC-196) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damcou
requested changes
Dec 14, 2021
There was a problem hiding this comment.
Thanks @DevinCodes , looks good, just need a few changes.
Could you also generate the client with yarn generate and commit it please ?
It could also be perfect to add the related tests in the CTS directory please 🙏
damcou
requested changes
Dec 15, 2021
shortcuts
previously approved these changes
Dec 17, 2021
damcou
previously approved these changes
Dec 17, 2021
shortcuts
approved these changes
Dec 17, 2021
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the spec for all vault endpoints.