Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): ingestion destinations and transformations #3477

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2703

Changes included:

  • list allows pagination
  • destinations have an optional transformationIDs parameter

@shortcuts shortcuts self-assigned this Aug 5, 2024
@shortcuts shortcuts requested a review from a team as a code owner August 5, 2024 13:31
@shortcuts shortcuts requested review from morganleroi and Fluf22 August 5, 2024 13:31
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 5, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 65af1ab6114d4a5f7eafdc3462d5e0817651a4ee
🍃 Generated commit 51a34bfcd26b50e7a7b96f728940cb4b9ecdb013
🌲 Generated branch generated/fix/ingestion-specs
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
php 1364
javascript 1347
csharp 1088
java 931
ruby 870
swift 735
python 725
kotlin 470
go 465

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍🏻

@shortcuts shortcuts enabled auto-merge (squash) August 5, 2024 13:41
Copy link

github-actions bot commented Aug 5, 2024

@shortcuts shortcuts merged commit cdd673d into main Aug 5, 2024
21 checks passed
@shortcuts shortcuts deleted the fix/ingestion-specs branch August 5, 2024 13:49
algolia-bot added a commit that referenced this pull request Aug 5, 2024
…ated) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3477

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants