fix(go): explicit usage of browse helpers #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
approved these changes
Jul 25, 2024
Comment on lines
+3
to
+6
| maxRetries: -1, | ||
| timeout: func(count int) time.Duration { | ||
| return 0 * time.Millisecond | ||
| }, |
There was a problem hiding this comment.
is this expected to change defaults?
There was a problem hiding this comment.
yes it shouldn't wait by default, the function calling this should provide a default.
This was causing the browseObjects helper to wait 1s between each call for no reason
| @@ -124,18 +111,18 @@ func (c *APIClient) WaitForTask( | |||
| // provide a defalut timeout function | |||
| opts = append([]IterableOption{WithTimeout(func(count int) time.Duration { | |||
| return time.Duration(min(200*count, 5000)) * time.Millisecond | |||
| })}, opts...) | |||
| }), WithMaxRetries(50)}, opts...) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Don't silence the error on
CreateIterable, add some doc, and make the usage more explicit by only returningerrorand force to useWithAggragator.