Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go): expose ExposeIntermediateNetworkErrors to the config #3404

Merged
merged 1 commit into from
Jul 21, 2024
Merged

feat(go): expose ExposeIntermediateNetworkErrors to the config #3404

merged 1 commit into from
Jul 21, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 21, 2024

🧭 What and Why

Fixes an old todo.

@millotp millotp self-assigned this Jul 21, 2024
@millotp millotp requested a review from a team as a code owner July 21, 2024 07:43
@millotp millotp requested review from morganleroi and Fluf22 July 21, 2024 07:43
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 21, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by 67317f91659077753eb2440351e1ac8d31bd499d
🍃 Generated commit bd1d15f8ae7ed8dfad1b67874e70d376d835f65a
🌲 Generated branch generated/feat/expose-go

Fluf22
Fluf22 approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we offer the same option in the other clients?
This could be done later of course

@github-actions GitHub Actions
Copy link

🚀 Deployed on https://669cbe4a59d015a41960b45c--api-clients-automation.netlify.app

morganleroi
morganleroi approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@millotp
Copy link
Collaborator Author

millotp commented Jul 21, 2024

Should we offer the same option in the other clients? This could be done later of course

maybe, there is already work done for ruby #3384

@millotp millotp merged commit 82562cc into main Jul 21, 2024
12 checks passed
@millotp millotp deleted the feat/expose-go branch July 21, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganleroi morganleroi morganleroi approved these changes

@Fluf22 Fluf22 Fluf22 approved these changes

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@millotp @algolia-bot @morganleroi @Fluf22