chore(ci): fix commit parsing logic #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
eunjae-lee
commented
Apr 5, 2022
| @@ -179,6 +178,13 @@ async function createReleaseIssue(): Promise<void> { | |||
| const commitsWithUnknownLanguageScope: string[] = []; | |||
| const commitsWithoutLanguageScope: string[] = []; | |||
|
|
|||
| // Remove the local tag, and fetch it from the remote. | |||
| // We move the `released` tag as we release, so we need to make it up-to-date. | |||
| await run(`git tag -d ${RELEASED_TAG}`); | |||
There was a problem hiding this comment.
As explained above, we need to remove the local tag, and fetch it from the remote.
eunjae-lee
commented
Apr 5, 2022
| @@ -269,7 +269,9 @@ async function processRelease(): Promise<void> { | |||
| await run(`git push`); | |||
|
|
|||
| // remove old `released` tag | |||
| await run(`git fetch origin refs/tags/released:refs/tags/released`); | |||
| await run( | |||
shortcuts
reviewed
Apr 5, 2022
| const LENGTH_SHA1 = 8; | ||
| const hash = commit.slice(0, LENGTH_SHA1); | ||
| let message = commit.slice(LENGTH_SHA1 + 1); | ||
| const hash = commit.split(' ')[0]; |
There was a problem hiding this comment.
Do we only care about feat and fix commits here? If so, we can use them as a split, so we don't rely on spaces or hash length
There was a problem hiding this comment.
Actually I just discovered --abbrev=8 option!
There was a problem hiding this comment.
Wouldn't it be safer to abbrev 7? Or does abbrev 8 on a 7 char long hash works?
There was a problem hiding this comment.
Ok nevermind I guess I got it now :D
f147bda to
af879d5
Compare
af879d5 to
9e70d33
Compare
millotp
approved these changes
Apr 6, 2022
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
🧪 Test