-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: keep guides for docs close to snippets #3354
Conversation
✔️ Code generated!
|
I think you need to update |
I've ignored it on purpose, it still works but will be removed in a week or so, so... it's fine for now I guess |
if the files are not generated nor commited it will fail right ? with a |
since the build docs steps is in the same as the website build I think it's fine, even if it's not committed it still has access to it directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes okay I thought you moved the generated folder too
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
since the split of the CI, the generation of the snippets is done outside of the release step, but the website generated folder isn't pushed to the repo, see https://github.com/algolia/api-clients-automation/actions/runs/9908119385/job/27373697603
since this folder will disappear when the algolia doc leverages our snippets, we can already move our snippet guides in a dedicated folder that we push and keep code in, so the release step can also leverage it