Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): add api key helper test #3338

Merged
merged 20 commits into from
Jul 18, 2024
Merged

feat(clients): add api key helper test #3338

merged 20 commits into from
Jul 18, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jul 9, 2024 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-2507

Changes included:

  • generate test for waitForApiKey helpers
  • handle expected null response
  • add ts mock server

@Fluf22 Fluf22 requested a review from a team as a code owner July 9, 2024 10:31
@Fluf22 Fluf22 requested review from morganleroi and millotp July 9, 2024 10:31
@Fluf22 Fluf22 self-assigned this Jul 9, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 9, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by 207a3b249915eb36ffd3dd1a910087d55605cc69
🍃 Generated commit 0c2874d86329872045b1709609b460e4896f5c86
🌲 Generated branch generated/feat/api-key-e2e

@Fluf22 Fluf22 force-pushed the feat/api-key-e2e branch 7 times, most recently from d8a9ac3 to 48a59b0 Compare July 12, 2024 15:05
@millotp millotp force-pushed the feat/api-key-e2e branch from 3b34349 to 58ad4e4 Compare July 17, 2024 21:56
@millotp millotp changed the base branch from main to fix/go-opts-2 July 17, 2024 21:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

🚀 Deployed on https://6698d15287626671ff966af9--api-clients-automation.netlify.app

millotp
millotp previously approved these changes Jul 17, 2024
View reviewed changes
Base automatically changed from fix/go-opts-2 to main July 18, 2024 07:36
@millotp millotp dismissed their stale review July 18, 2024 07:36

The base branch was changed.

@millotp millotp force-pushed the feat/api-key-e2e branch from 6dd191d to 7665aef Compare July 18, 2024 07:53
@millotp millotp merged commit a68907d into main Jul 18, 2024
21 checks passed
@millotp millotp deleted the feat/api-key-e2e branch July 18, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fluf22 @algolia-bot @millotp