Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tooling): specs script #33

Merged
merged 8 commits into from
Dec 13, 2021
Merged

chore(tooling): specs script #33

merged 8 commits into from
Dec 13, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Dec 9, 2021 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-222

Changes included:

Follow up of #32:

  • Adds a script to build and validate specs
  • Automate retrieving of clients and languages based on the openapitools.json file
  • Bit of logging to know where we are in the script
  • Update CI to break down specs jobs

🧪 Test

CI :D

@shortcuts shortcuts force-pushed the chore/specs-script branch 2 times, most recently from e7c213a to 7988cb3 Compare December 9, 2021 15:11
Base automatically changed from chore/generation-script to main December 9, 2021 15:32
@shortcuts shortcuts marked this pull request as ready for review December 9, 2021 16:07
@shortcuts shortcuts requested a review from millotp December 9, 2021 16:07
millotp
millotp reviewed Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spec script !

@shortcuts shortcuts requested a review from millotp December 13, 2021 10:55
millotp
millotp previously approved these changes Dec 13, 2021
View reviewed changes
millotp
millotp approved these changes Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !

@shortcuts shortcuts merged commit dd301eb into main Dec 13, 2021
@shortcuts shortcuts deleted the chore/specs-script branch December 13, 2021 11:32
@shortcuts shortcuts self-assigned this Dec 16, 2021
shortcuts added a commit that referenced this pull request Apr 22, 2022
@shortcuts
chore(tooling): specs script (#33)
318e160
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shortcuts @millotp