Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): use createIterable method like in other clients #3216

Merged
merged 9 commits into from
Jun 21, 2024
Merged

fix(go): use createIterable method like in other clients #3216

merged 9 commits into from
Jun 21, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jun 20, 2024 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1813

Changes included:

  • fix typo in Swift client
  • add createIterable method

@Fluf22 Fluf22 requested a review from a team as a code owner June 20, 2024 15:19
@Fluf22 Fluf22 requested review from millotp and shortcuts June 20, 2024 15:19
@Fluf22 Fluf22 self-assigned this Jun 20, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 20, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

🚀 Deployed on https://6675a1cab8e00cae5a9863da--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 20, 2024 17:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 20, 2024 21:40 Inactive
shortcuts
shortcuts reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks super nice, would be great to have struct with Options to better handle default values in the wait helpers but that's for a next iteration!

@github-actions github-actions bot temporarily deployed to pull request June 21, 2024 08:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 21, 2024 09:51 Inactive
@Fluf22 Fluf22 requested a review from shortcuts June 21, 2024 12:15
@github-actions github-actions bot temporarily deployed to pull request June 21, 2024 12:29 Inactive
shortcuts
shortcuts approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

joli

@Fluf22 Fluf22 enabled auto-merge (squash) June 21, 2024 14:11
@github-actions github-actions bot temporarily deployed to pull request June 21, 2024 14:22 Inactive
@shortcuts shortcuts disabled auto-merge June 21, 2024 15:43
@shortcuts shortcuts enabled auto-merge June 21, 2024 15:43
@github-actions github-actions bot temporarily deployed to pull request June 21, 2024 15:52 Inactive
@shortcuts shortcuts added this pull request to the merge queue Jun 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2024
@shortcuts shortcuts merged commit a22e83d into main Jun 21, 2024
13 checks passed
@shortcuts shortcuts deleted the fix/go-create-iterable branch June 21, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fluf22 @algolia-bot @shortcuts