Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): js ci when algoliasearch is missing #3213

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

see #3212, js fails to run tests for algoliasearch because it's not supposed to run, we can ignore it when it's the case

@shortcuts shortcuts self-assigned this Jun 19, 2024
@shortcuts shortcuts requested a review from a team as a code owner June 19, 2024 18:46
@shortcuts shortcuts requested review from morganleroi and Fluf22 June 19, 2024 18:46
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 19, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts enabled auto-merge (squash) June 19, 2024 18:59
Copy link

@github-actions github-actions bot temporarily deployed to pull request June 19, 2024 19:06 Inactive
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny edge case

@shortcuts shortcuts merged commit 65775e4 into main Jun 19, 2024
21 checks passed
@shortcuts shortcuts deleted the chore/javascript-ci branch June 19, 2024 22:27
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 19, 2024
algolia/api-clients-automation#3213

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants