Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): push to correct directories #3211

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 19, 2024

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

push the images to the assets directory, also removed the clearing folder logic to prevent deleting unwanted doc stuff, see https://github.com/algolia/doc/pull/9098

@shortcuts shortcuts self-assigned this Jun 19, 2024
@shortcuts shortcuts requested a review from a team as a code owner June 19, 2024 13:02
@shortcuts shortcuts requested review from damcou and Fluf22 June 19, 2024 13:02
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 19, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts
Copy link
Member Author

(waiting on Kai's confirmation to merge but looks good on the docs side too)

Copy link

@github-actions github-actions bot temporarily deployed to pull request June 19, 2024 13:19 Inactive
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 I wanted to approve, too

@shortcuts shortcuts merged commit d55eee1 into main Jun 19, 2024
24 checks passed
@shortcuts shortcuts deleted the fix/spread-to-algolia-docs branch June 19, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants