Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): automatically update swiftformat #3207

Merged
merged 2 commits into from
Jun 18, 2024
Merged

chore(deps): automatically update swiftformat #3207

merged 2 commits into from
Jun 18, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 18, 2024 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-2469

We have a discrepancy between local and CI that make weird format on the generated code, we can sync the versions.

@millotp millotp self-assigned this Jun 18, 2024
@millotp millotp requested a review from a team as a code owner June 18, 2024 16:11
@millotp millotp requested review from morganleroi and shortcuts June 18, 2024 16:11
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 18, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

🚀 Deployed on https://6671ea4070b58f46449eb56a--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 16:35 Inactive
shortcuts
shortcuts approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good idea

@millotp millotp enabled auto-merge (squash) June 18, 2024 19:29
@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 20:12 Inactive
@millotp millotp merged commit b2b7cd2 into main Jun 18, 2024
21 checks passed
@millotp millotp deleted the chore/swiftversion branch June 18, 2024 20:13
@shortcuts shortcuts mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millotp @algolia-bot @shortcuts