-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(clients): use the ruff python formatter #3204
Conversation
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the previous ternary syntax? It was more readable
Other than that, looks really great!
I tried too but it's not supported yet, there is a feature request astral-sh/ruff#9722 |
wdyt about the Outliers.from_dict(obj.get("outliers")) if obj.get("outliers") is not None else None with obj.get("outliers") and Outliers.from_dict(obj.get("outliers")) |
explicit* None seems better though :/ I guess we can wait for them to support it Have you tried adding parentheses around the ternaries in the template, just to see if it's correctly indented? |
Indeed that works perfectly ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niceee
🧭 What and Why
The ruff formatter is blazingly fast and reduces the number of deps for python.