Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): waitForAllRelease works with dart #3176

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 13, 2024

🧭 What and Why

The waitForAllRelease script doesn't work for dart for some reason when using the workflowID with a branch.
Now the api supports using the name of the yaml directly so we can simplify the script, and use better types.

@millotp millotp self-assigned this Jun 13, 2024
@millotp millotp requested a review from a team as a code owner June 13, 2024 14:08
@millotp millotp requested review from morganleroi and shortcuts June 13, 2024 14:08
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 13, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much clear!!

@millotp millotp enabled auto-merge (squash) June 13, 2024 14:27
@millotp millotp disabled auto-merge June 13, 2024 14:27
Copy link

github-actions bot commented Jun 13, 2024

@github-actions github-actions bot temporarily deployed to pull request June 13, 2024 14:34 Inactive
@millotp millotp enabled auto-merge (squash) June 13, 2024 14:47
@github-actions github-actions bot temporarily deployed to pull request June 13, 2024 15:01 Inactive
@millotp millotp merged commit a0aeec7 into main Jun 13, 2024
25 checks passed
@millotp millotp deleted the fix/wait-script branch June 13, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants